Fix: Correct shipment resolving

src/Shipping/Carriers/Acs/AcsRateDriver.php

@@ -9,16 +9,19 @@ use Lunar\Shipping\Interfaces\ShippingRateInterface;
 use Lunar\Shipping\Models\ShippingRate;
 use Modules\Core\Shipping\Carriers\Acs\Exceptions\AcsApiException;
 use Modules\Core\Shipping\Concerns\CachesLivePricing;
+use Modules\Core\Shipping\Concerns\ExcludesRestrictedProducts;
 use Modules\Core\Shipping\Concerns\ResolvesFixedPricing;
 use Modules\Core\Shipping\Contracts\DeclaresFulfillmentType;
+use Modules\Core\Shipping\Contracts\SupportsCashCollection;
 use Modules\Core\Shipping\Contracts\SupportsLivePricing;
 use Modules\Core\Shipping\Support\ShippingMethodName;
 use Modules\Core\Shipping\Support\WeightCalculator;
 
-class AcsRateDriver implements ShippingRateInterface, SupportsLivePricing, DeclaresFulfillmentType
+class AcsRateDriver implements ShippingRateInterface, SupportsLivePricing, DeclaresFulfillmentType, SupportsCashCollection
 {
     use ResolvesFixedPricing;
     use CachesLivePricing;
+    use ExcludesRestrictedProducts;
 
     public ShippingRate $shippingRate;
 
@@ -37,6 +40,11 @@ class AcsRateDriver implements ShippingRateInterface, SupportsLivePricing, Decla
         return 'carrier';
     }
 
+    public function collectsCash(): bool
+    {
+        return true;
+    }
+
     public function description(): string
     {
         return 'Live rate quote from ACS Courier.';
@@ -48,6 +56,10 @@ class AcsRateDriver implements ShippingRateInterface, SupportsLivePricing, Decla
         $shippingMethod = $shippingRate->shippingMethod;
         $cart = $shippingOptionRequest->cart;
 
+        if ($this->cartHasExcludedProducts($shippingRate, $cart)) {
+            return null;
+        }
+
         if (($shippingMethod->data['charge_by'] ?? 'cart_total') !== 'live') {
             return $this->resolveFixedPrice($shippingRate, $shippingMethod, $cart);
         }

src/Shipping/Carriers/BoxNow/BoxNowRateDriver.php

@@ -6,6 +6,7 @@ use Lunar\DataTypes\ShippingOption;
 use Lunar\Shipping\DataTransferObjects\ShippingOptionRequest;
 use Lunar\Shipping\Interfaces\ShippingRateInterface;
 use Lunar\Shipping\Models\ShippingRate;
+use Modules\Core\Shipping\Concerns\ExcludesRestrictedProducts;
 use Modules\Core\Shipping\Concerns\ResolvesFixedPricing;
 use Modules\Core\Shipping\Contracts\DeclaresFulfillmentType;
 
@@ -18,6 +19,7 @@ use Modules\Core\Shipping\Contracts\DeclaresFulfillmentType;
 class BoxNowRateDriver implements ShippingRateInterface, DeclaresFulfillmentType
 {
     use ResolvesFixedPricing;
+    use ExcludesRestrictedProducts;
 
     public ShippingRate $shippingRate;
 
@@ -38,6 +40,10 @@ class BoxNowRateDriver implements ShippingRateInterface, DeclaresFulfillmentType
 
     public function resolve(ShippingOptionRequest $shippingOptionRequest): ?ShippingOption
     {
+        if ($this->cartHasExcludedProducts($shippingOptionRequest->shippingRate, $shippingOptionRequest->cart)) {
+            return null;
+        }
+
         return $this->resolveFixedPrice(
             $shippingOptionRequest->shippingRate,
             $shippingOptionRequest->shippingRate->shippingMethod,

src/Shipping/Carriers/StorePickup/StorePickupRateDriver.php

@@ -0,0 +1,75 @@
+<?php
+
+namespace Modules\Core\Shipping\Carriers\StorePickup;
+
+use Lunar\DataTypes\ShippingOption;
+use Lunar\Shipping\DataTransferObjects\ShippingOptionRequest;
+use Lunar\Shipping\Interfaces\ShippingRateInterface;
+use Lunar\Shipping\Models\ShippingRate;
+use Modules\Core\Shipping\Concerns\ExcludesRestrictedProducts;
+use Modules\Core\Shipping\Concerns\ResolvesFixedPricing;
+use Modules\Core\Shipping\Contracts\DeclaresFulfillmentType;
+
+/**
+ * First-party replacement for lunarphp/table-rate-shipping's own Collection
+ * driver — same shape as AcsRateDriver/BoxNowRateDriver, unlike the vendor
+ * generic drivers (flat-rate/ship-by/free-shipping/collection), which this
+ * module no longer registers (see ShippingServiceProvider). Two reasons
+ * this exists rather than keeping the vendor driver:
+ *
+ * 1. Collection::resolve() reads $shippingMethod->name directly instead of
+ *    through Modules\Core\Shipping\Support\ShippingMethodName::resolve() —
+ *    ShippingMethod has no cast for that locale-keyed JSON column (see
+ *    ShippingMethodName's own docblock), so the storefront showed the raw
+ *    JSON blob as the option's name instead of the translated string.
+ * 2. Unambiguously store pickup, like ACS/Box Now are unambiguously
+ *    carrier — implementing DeclaresFulfillmentType means a merchant never
+ *    has to separately pick "Collect in store" from the generic
+ *    data['fulfillment_type'] field (see that contract's own docblock).
+ *
+ * No live pricing — there's no API for in-person pickup, just the method's
+ * own charge_by + price-break configuration (usually free), the same
+ * mechanism Box Now uses.
+ */
+class StorePickupRateDriver implements ShippingRateInterface, DeclaresFulfillmentType
+{
+    use ResolvesFixedPricing;
+    use ExcludesRestrictedProducts;
+
+    public ShippingRate $shippingRate;
+
+    public function name(): string
+    {
+        return 'Store Pickup';
+    }
+
+    public function fulfillmentType(): string
+    {
+        return 'store_pickup';
+    }
+
+    public function description(): string
+    {
+        return 'Collect your order in store.';
+    }
+
+    public function resolve(ShippingOptionRequest $shippingOptionRequest): ?ShippingOption
+    {
+        if ($this->cartHasExcludedProducts($shippingOptionRequest->shippingRate, $shippingOptionRequest->cart)) {
+            return null;
+        }
+
+        return $this->resolveFixedPrice(
+            $shippingOptionRequest->shippingRate,
+            $shippingOptionRequest->shippingRate->shippingMethod,
+            $shippingOptionRequest->cart,
+        );
+    }
+
+    public function on(ShippingRate $shippingRate): self
+    {
+        $this->shippingRate = $shippingRate;
+
+        return $this;
+    }
+}