Feat: Updates to Payments, Checkout Services, Payment Events

src/Payment/Drivers/OfflinePaymentDriver.php

@@ -2,35 +2,28 @@
 
 namespace Modules\Core\Payment\Drivers;
 
-use Lunar\Exceptions\Carts\CartException;
-use Lunar\Exceptions\DisallowMultipleCartOrdersException;
-use Lunar\Exceptions\FingerprintMismatchException;
 use Lunar\Models\Cart;
-use Lunar\Models\Order;
-use Modules\Core\Checkout\Contracts\PaymentDriver;
-use Modules\Core\Checkout\Services\CheckoutService;
+use Modules\Core\Checkout\Events\OrderPlaced;
+use Modules\Core\Checkout\Events\PaymentConfirmed;
+use Modules\Core\Payment\Contracts\PaymentDriver;
 
 /**
  * Shared by every payment type with no real gateway to confirm against —
  * cash-in-hand, cash-on-delivery — where the shopper pays at pickup/on
- * delivery, not at checkout. confirm() has nothing to wait on, so it places
- * the order immediately, same as Lunar's own OfflinePayment would, but
- * through CheckoutService::placeOrder() so it goes through the same
- * fingerprint check every other driver does. $data is unused: nothing about
- * this confirmation depends on gateway-specific payload.
+ * delivery, not at checkout. confirm() has nothing to wait on, so it
+ * dispatches PaymentConfirmed immediately, same moment Lunar's own
+ * OfflinePayment would place the order — but the actual placement now
+ * happens in CheckoutService::onPaymentConfirmed(), not here. $data is
+ * unused: nothing about this confirmation depends on gateway-specific
+ * payload.
  *
- * Sets the order status to config("lunar.payments.types.{$type}.authorized")
- * afterward, using the type actually confirmed — not a hardcoded key —
- * since this one driver is shared across multiple types.
- * placeOrder() itself leaves the order at Lunar's configured draft_status,
- * same as every driver is responsible for moving it on from.
+ * The status-mapping step this driver used to do inline right after
+ * placeOrder() returned now happens in onOrderPlaced() below instead —
+ * see PaymentDriver's docblock for why a driver can no longer rely on
+ * placeOrder()'s return value.
  */
 class OfflinePaymentDriver implements PaymentDriver
 {
-    public function __construct(
-        private readonly CheckoutService $checkout,
-    ) {}
-
     /**
      * Always true — no external dependency to be missing.
      */
@@ -39,19 +32,30 @@ class OfflinePaymentDriver implements PaymentDriver
         return true;
     }
 
-    /**
-     * @throws FingerprintMismatchException
-     * @throws CartException
-     * @throws DisallowMultipleCartOrdersException
-     */
-    public function confirm(Cart $cart, string $type, string $fingerprint, array $data): Order
+    public function confirm(Cart $cart, string $type, string $fingerprint, array $data): void
     {
-        $order = $this->checkout->placeOrder($fingerprint);
+        PaymentConfirmed::dispatch($cart, $type, $fingerprint, $data);
+    }
+
+    /**
+     * Registered in PaymentServiceProvider. Every offline-style type
+     * shares this one driver, so $order->meta['payment_method'] is checked
+     * against config('lunar.payments.types') to confirm the placed order
+     * actually belongs to one of them, rather than assuming every
+     * OrderPlaced is this driver's to act on — a Stripe order placed via
+     * StripePaymentDriver fires the same event.
+     */
+    public function onOrderPlaced(OrderPlaced $event): void
+    {
+        $order = $event->order;
+        $type = $order->meta['payment_method'] ?? null;
+
+        if (! $type || config("lunar.payments.types.{$type}.payment_driver") !== self::class) {
+            return;
+        }
 
         $order->update([
             'status' => config("lunar.payments.types.{$type}.authorized", $order->status),
         ]);
-
-        return $order->refresh();
     }
 }