Feat: Privacy Concern redesign to match project structure

docs/privacy.md

@@ -169,7 +169,7 @@ no one — a business-account erasure must never block anyone's access.
 `Modules\Core\Auth\Services\UserOtpService` — nothing else changes).
 
 ```php
-use Modules\Core\Privacy\PrivacyService;
+use Modules\Core\Privacy\Services\PrivacyService;
 
 $service = app(PrivacyService::class);
 

src/Command/ProcessErasureRequestsCommand.php

@@ -3,7 +3,7 @@
 namespace Modules\Core\Command;
 
 use Illuminate\Console\Command;
-use Modules\Core\Privacy\ErasureRequestStatus;
+use Modules\Core\Privacy\Enums\ErasureRequestStatus;
 use Modules\Core\Privacy\Jobs\EraseDataSubjectJob;
 use Modules\Core\Privacy\Models\DataErasureRequest;
 

src/Privacy/Contracts/PersonalDataProvider.php

@@ -2,10 +2,10 @@
 
 namespace Modules\Core\Privacy\Contracts;
 
-use Modules\Core\Privacy\CustomerSubject;
+use Modules\Core\Privacy\DTOs\CustomerSubject;
-use Modules\Core\Privacy\ProviderErasureResult;
+use Modules\Core\Privacy\DTOs\ProviderErasureResult;
-use Modules\Core\Privacy\ProviderExportResult;
+use Modules\Core\Privacy\DTOs\ProviderExportResult;
-use Modules\Core\Privacy\UserSubject;
+use Modules\Core\Privacy\DTOs\UserSubject;
 
 /**
  * Implemented by any module that holds personal data and wants it included in

src/Privacy/DTOs/CustomerSubject.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Modules\Core\Privacy;
+namespace Modules\Core\Privacy\DTOs;
 
 use Lunar\Models\Customer;
 

src/Privacy/DTOs/ErasureReport.php

@@ -1,6 +1,8 @@
 <?php
 
-namespace Modules\Core\Privacy;
+namespace Modules\Core\Privacy\DTOs;
+
+use Modules\Core\Privacy\Enums\ErasureOutcome;
 
 /**
  * Every registered provider's outcome, assembled into one right-of-erasure response

src/Privacy/DTOs/ExportReport.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Modules\Core\Privacy;
+namespace Modules\Core\Privacy\DTOs;
 
 /**
  * Every registered provider's export, assembled into one right-of-access response.

src/Privacy/DTOs/ProviderErasureResult.php

@@ -1,6 +1,8 @@
 <?php
 
-namespace Modules\Core\Privacy;
+namespace Modules\Core\Privacy\DTOs;
+
+use Modules\Core\Privacy\Enums\ErasureOutcome;
 
 /**
  * One provider's outcome on an erasure request. `reason` is required whenever

src/Privacy/DTOs/ProviderExportResult.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Modules\Core\Privacy;
+namespace Modules\Core\Privacy\DTOs;
 
 /**
  * One provider's contribution to a right-of-access export. `provider` is a short,

src/Privacy/DTOs/UserSubject.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Modules\Core\Privacy;
+namespace Modules\Core\Privacy\DTOs;
 
 use Illuminate\Contracts\Auth\Authenticatable;
 use Lunar\Base\LunarUser;

src/Privacy/Enums/ErasureOutcome.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Modules\Core\Privacy;
+namespace Modules\Core\Privacy\Enums;
 
 /**
  * What actually happened to a provider's data on an erasure request. None of these

src/Privacy/Enums/ErasureRequestStatus.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Modules\Core\Privacy;
+namespace Modules\Core\Privacy\Enums;
 
 enum ErasureRequestStatus: string
 {

src/Privacy/Enums/ExportRequestStatus.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Modules\Core\Privacy;
+namespace Modules\Core\Privacy\Enums;
 
 enum ExportRequestStatus: string
 {

src/Privacy/Events/PersonalDataGathered.php

@@ -2,7 +2,7 @@
 
 namespace Modules\Core\Privacy\Events;
 
-use Modules\Core\Privacy\ExportReport;
+use Modules\Core\Privacy\DTOs\ExportReport;
 use Modules\Core\Privacy\Models\DataExportRequest;
 
 /**

src/Privacy/Filament/Extensions/CustomerErasureActionsExtension.php

@@ -8,7 +8,7 @@ use Filament\Notifications\Notification;
 use Lunar\Admin\Support\Extending\BaseExtension;
 use Lunar\Models\Customer;
 use Modules\Core\Auth\Models\Staff;
-use Modules\Core\Privacy\PrivacyService;
+use Modules\Core\Privacy\Services\PrivacyService;
 
 /**
  * Adds "Request erasure" / "Request export" header actions to the Customer

src/Privacy/Filament/Resources/DataErasureRequestResource.php

@@ -15,10 +15,10 @@ use Filament\Tables\Columns\TextColumn;
 use Filament\Tables\Filters\SelectFilter;
 use Filament\Tables\Table;
 use Lunar\Models\Customer;
-use Modules\Core\Privacy\ErasureRequestStatus;
+use Modules\Core\Privacy\Enums\ErasureRequestStatus;
 use Modules\Core\Privacy\Filament\Resources\DataErasureRequestResource\Pages;
 use Modules\Core\Privacy\Models\DataErasureRequest;
-use Modules\Core\Privacy\PrivacyService;
+use Modules\Core\Privacy\Services\PrivacyService;
 
 /**
  * Read-mostly audit view over data_erasure_requests — staff can see every request

src/Privacy/Filament/Resources/DataExportRequestResource.php

@@ -13,7 +13,7 @@ use Filament\Resources\Resource;
 use Filament\Tables\Columns\TextColumn;
 use Filament\Tables\Filters\SelectFilter;
 use Filament\Tables\Table;
-use Modules\Core\Privacy\ExportRequestStatus;
+use Modules\Core\Privacy\Enums\ExportRequestStatus;
 use Modules\Core\Privacy\Filament\Resources\DataExportRequestResource\Pages;
 use Modules\Core\Privacy\Models\DataErasureRequest;
 use Modules\Core\Privacy\Models\DataExportRequest;

src/Privacy/Jobs/EraseDataSubjectJob.php

@@ -8,7 +8,7 @@ use Illuminate\Foundation\Bus\Dispatchable;
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
 use Modules\Core\Privacy\Models\DataErasureRequest;
-use Modules\Core\Privacy\PrivacyService;
+use Modules\Core\Privacy\Services\PrivacyService;
 
 /**
  * Runs PrivacyService::completeErasure() for one due DataErasureRequest, dispatched

src/Privacy/Jobs/ExportDataSubjectJob.php

@@ -9,13 +9,13 @@ use Illuminate\Foundation\Bus\Dispatchable;
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
 use Illuminate\Support\Facades\Event;
-use Modules\Core\Privacy\CustomerSubject;
+use Modules\Core\Privacy\DTOs\CustomerSubject;
 use Modules\Core\Privacy\Events\PersonalDataGathered;
-use Modules\Core\Privacy\ExportReport;
+use Modules\Core\Privacy\DTOs\ExportReport;
-use Modules\Core\Privacy\ExportRequestStatus;
+use Modules\Core\Privacy\Enums\ExportRequestStatus;
 use Modules\Core\Privacy\Models\DataExportRequest;
-use Modules\Core\Privacy\PrivacyManager;
+use Modules\Core\Privacy\Services\PrivacyManager;
-use Modules\Core\Privacy\UserSubject;
+use Modules\Core\Privacy\DTOs\UserSubject;
 
 /**
  * Gathers every registered PersonalDataProvider's export data for one request, all
@@ -27,7 +27,7 @@ use Modules\Core\Privacy\UserSubject;
  * generated PDF), that's the point to reconsider — not before.
  *
  * Calls each provider's *ForCustomer() or *ForUser() method depending on the
- * request's polymorphic subject — see Modules\Core\Privacy\PrivacyService and
+ * request's polymorphic subject — see Modules\Core\Privacy\Services\PrivacyService and
  * docs/privacy.md "User-scope vs Customer-scope".
  *
  * Writing the gathered data to a file is intentionally NOT done here — see

src/Privacy/Listeners/CancelErasureOnLoginListener.php

@@ -4,9 +4,9 @@ namespace Modules\Core\Privacy\Listeners;
 
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Modules\Core\Auth\Events\UserAuthenticated;
-use Modules\Core\Privacy\ErasureRequestStatus;
+use Modules\Core\Privacy\Enums\ErasureRequestStatus;
 use Modules\Core\Privacy\Models\DataErasureRequest;
-use Modules\Core\Privacy\PrivacyService;
+use Modules\Core\Privacy\Services\PrivacyService;
 
 /**
  * Logging back in during a pending erasure request's grace period IS the "I

src/Privacy/Listeners/CascadeCustomerErasureListener.php

@@ -7,7 +7,7 @@ use Illuminate\Contracts\Queue\ShouldQueue;
 use Lunar\Base\LunarUser;
 use Lunar\Models\Customer;
 use Modules\Core\Privacy\Events\UserErasureRequested;
-use Modules\Core\Privacy\PrivacyService;
+use Modules\Core\Privacy\Services\PrivacyService;
 
 /**
  * When a User's erasure leaves a Customer account with no remaining User at all,

src/Privacy/Listeners/WriteExportToCsvListener.php

@@ -8,7 +8,7 @@ use Modules\Core\Export\CsvColumn;
 use Modules\Core\Export\CsvWriter;
 use Modules\Core\Privacy\Events\PersonalDataExportFileWritten;
 use Modules\Core\Privacy\Events\PersonalDataGathered;
-use Modules\Core\Privacy\ExportRequestStatus;
+use Modules\Core\Privacy\Enums\ExportRequestStatus;
 use ZipArchive;
 
 /**

src/Privacy/Models/DataErasureRequest.php

@@ -7,12 +7,12 @@ use Illuminate\Database\Eloquent\Relations\BelongsTo;
 use Illuminate\Database\Eloquent\Relations\HasMany;
 use Illuminate\Database\Eloquent\Relations\MorphTo;
 use Lunar\Models\Customer;
-use Modules\Core\Privacy\ErasureRequestStatus;
+use Modules\Core\Privacy\Enums\ErasureRequestStatus;
 
 /**
  * A pending, cancelled, or completed right-of-erasure request — the grace-period
  * record between "subject/staff asked for this" and "providers actually erased
- * their data" (see Modules\Core\Privacy\PrivacyService, which creates/processes
+ * their data" (see Modules\Core\Privacy\Services\PrivacyService, which creates/processes
  * these).
  *
  * `subject` is polymorphic — either a Lunar Customer (business account) or a User

src/Privacy/Models/DataExportRequest.php

@@ -5,7 +5,7 @@ namespace Modules\Core\Privacy\Models;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\MorphTo;
 use Lunar\Models\Customer;
-use Modules\Core\Privacy\ExportRequestStatus;
+use Modules\Core\Privacy\Enums\ExportRequestStatus;
 
 /**
  * A right-of-access export request. Created synchronously (fast — one insert), then

src/Privacy/Providers/AddressDataProvider.php

@@ -4,11 +4,11 @@ namespace Modules\Core\Privacy\Providers;
 
 use Lunar\Models\Address;
 use Modules\Core\Privacy\Contracts\PersonalDataProvider;
-use Modules\Core\Privacy\CustomerSubject;
+use Modules\Core\Privacy\DTOs\CustomerSubject;
-use Modules\Core\Privacy\ErasureOutcome;
+use Modules\Core\Privacy\Enums\ErasureOutcome;
-use Modules\Core\Privacy\ProviderErasureResult;
+use Modules\Core\Privacy\DTOs\ProviderErasureResult;
-use Modules\Core\Privacy\ProviderExportResult;
+use Modules\Core\Privacy\DTOs\ProviderExportResult;
-use Modules\Core\Privacy\UserSubject;
+use Modules\Core\Privacy\DTOs\UserSubject;
 
 /**
  * A customer's saved addresses (lunar_addresses) — belong to the Customer
@@ -17,7 +17,8 @@ use Modules\Core\Privacy\UserSubject;
  * OrderAddress, handled by OrderDataProvider), so they're freely deleted outright
  * rather than pseudonymized in place.
  */
-class AddressDataProvider implements PersonalDataProvider
+class 
+AddressDataProvider implements PersonalDataProvider
 {
     public function name(): string
     {

src/Privacy/Providers/CartDataProvider.php

@@ -5,11 +5,11 @@ namespace Modules\Core\Privacy\Providers;
 use Lunar\Models\Cart;
 use Lunar\Models\CartAddress;
 use Modules\Core\Privacy\Contracts\PersonalDataProvider;
-use Modules\Core\Privacy\CustomerSubject;
+use Modules\Core\Privacy\DTOs\CustomerSubject;
-use Modules\Core\Privacy\ErasureOutcome;
+use Modules\Core\Privacy\Enums\ErasureOutcome;
-use Modules\Core\Privacy\ProviderErasureResult;
+use Modules\Core\Privacy\DTOs\ProviderErasureResult;
-use Modules\Core\Privacy\ProviderExportResult;
+use Modules\Core\Privacy\DTOs\ProviderExportResult;
-use Modules\Core\Privacy\UserSubject;
+use Modules\Core\Privacy\DTOs\UserSubject;
 
 /**
  * Carts and cart addresses (lunar_carts, lunar_cart_addresses) belong to the

src/Privacy/Providers/CustomerDataProvider.php

@@ -4,11 +4,11 @@ namespace Modules\Core\Privacy\Providers;
 
 use Lunar\Models\Customer;
 use Modules\Core\Privacy\Contracts\PersonalDataProvider;
-use Modules\Core\Privacy\CustomerSubject;
+use Modules\Core\Privacy\DTOs\CustomerSubject;
-use Modules\Core\Privacy\ErasureOutcome;
+use Modules\Core\Privacy\Enums\ErasureOutcome;
-use Modules\Core\Privacy\ProviderErasureResult;
+use Modules\Core\Privacy\DTOs\ProviderErasureResult;
-use Modules\Core\Privacy\ProviderExportResult;
+use Modules\Core\Privacy\DTOs\ProviderExportResult;
-use Modules\Core\Privacy\UserSubject;
+use Modules\Core\Privacy\DTOs\UserSubject;
 
 /**
  * The Customer record itself (lunar_customers) and, on the User side, the User's

src/Privacy/Providers/OrderDataProvider.php

@@ -5,11 +5,11 @@ namespace Modules\Core\Privacy\Providers;
 use Lunar\Models\Order;
 use Lunar\Models\OrderAddress;
 use Modules\Core\Privacy\Contracts\PersonalDataProvider;
-use Modules\Core\Privacy\CustomerSubject;
+use Modules\Core\Privacy\DTOs\CustomerSubject;
-use Modules\Core\Privacy\ErasureOutcome;
+use Modules\Core\Privacy\Enums\ErasureOutcome;
-use Modules\Core\Privacy\ProviderErasureResult;
+use Modules\Core\Privacy\DTOs\ProviderErasureResult;
-use Modules\Core\Privacy\ProviderExportResult;
+use Modules\Core\Privacy\DTOs\ProviderExportResult;
-use Modules\Core\Privacy\UserSubject;
+use Modules\Core\Privacy\DTOs\UserSubject;
 
 /**
  * Orders and order addresses (lunar_orders, lunar_order_addresses) belong to the

src/Privacy/Providers/ReviewDataProvider.php

@@ -4,11 +4,11 @@ namespace Modules\Core\Privacy\Providers;
 
 use Illuminate\Database\Eloquent\Builder;
 use Modules\Core\Privacy\Contracts\PersonalDataProvider;
-use Modules\Core\Privacy\CustomerSubject;
+use Modules\Core\Privacy\DTOs\CustomerSubject;
-use Modules\Core\Privacy\ErasureOutcome;
+use Modules\Core\Privacy\Enums\ErasureOutcome;
-use Modules\Core\Privacy\ProviderErasureResult;
+use Modules\Core\Privacy\DTOs\ProviderErasureResult;
-use Modules\Core\Privacy\ProviderExportResult;
+use Modules\Core\Privacy\DTOs\ProviderExportResult;
-use Modules\Core\Privacy\UserSubject;
+use Modules\Core\Privacy\DTOs\UserSubject;
 use Modules\Core\Review\Models\ProductReview;
 
 /**

src/Privacy/RelationManagers/ErasureRequestsRelationManager.php

@@ -8,10 +8,10 @@ use Filament\Resources\RelationManagers\RelationManager;
 use Filament\Tables\Columns\TextColumn;
 use Filament\Tables\Filters\SelectFilter;
 use Filament\Tables\Table;
-use Modules\Core\Privacy\ErasureRequestStatus;
+use Modules\Core\Privacy\Enums\ErasureRequestStatus;
 use Modules\Core\Privacy\Filament\Resources\DataErasureRequestResource;
 use Modules\Core\Privacy\Models\DataErasureRequest;
-use Modules\Core\Privacy\PrivacyService;
+use Modules\Core\Privacy\Services\PrivacyService;
 
 /**
  * Lists erasure requests where the record being viewed (Customer or User) is the

src/Privacy/RelationManagers/ExportRequestsRelationManager.php

@@ -8,7 +8,7 @@ use Filament\Resources\RelationManagers\RelationManager;
 use Filament\Tables\Columns\TextColumn;
 use Filament\Tables\Filters\SelectFilter;
 use Filament\Tables\Table;
-use Modules\Core\Privacy\ExportRequestStatus;
+use Modules\Core\Privacy\Enums\ExportRequestStatus;
 use Modules\Core\Privacy\Filament\Resources\DataExportRequestResource;
 use Modules\Core\Privacy\Models\DataExportRequest;
 

src/Privacy/RelationManagers/UserRelationManager.php

@@ -11,7 +11,7 @@ use Filament\Tables\Table;
 use Illuminate\Database\Eloquent\Model;
 use Modules\Core\Customer\RelationManagers\UserRelationManager as CoreUserRelationManager;
 use Modules\Core\Privacy\Models\DataErasureRequest;
-use Modules\Core\Privacy\PrivacyService;
+use Modules\Core\Privacy\Services\PrivacyService;
 
 /**
  * Extends core's own Customer -> User relation manager to add:

src/Privacy/Services/PrivacyManager.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Modules\Core\Privacy;
+namespace Modules\Core\Privacy\Services;
 
 use LogicException;
 use Illuminate\Contracts\Container\Container;

src/Privacy/Services/PrivacyService.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Modules\Core\Privacy;
+namespace Modules\Core\Privacy\Services;
 
 use Illuminate\Contracts\Auth\Authenticatable;
 use Illuminate\Database\Eloquent\Model;
@@ -8,6 +8,12 @@ use Illuminate\Support\Facades\Event;
 use Lunar\Base\LunarUser;
 use Lunar\Models\Customer;
 use Modules\Core\Auth\Models\Staff;
+use Modules\Core\Privacy\DTOs\CustomerSubject;
+use Modules\Core\Privacy\DTOs\ErasureReport;
+use Modules\Core\Privacy\DTOs\ProviderErasureResult;
+use Modules\Core\Privacy\DTOs\UserSubject;
+use Modules\Core\Privacy\Enums\ErasureRequestStatus;
+use Modules\Core\Privacy\Enums\ExportRequestStatus;
 use Modules\Core\Privacy\Events\UserErasureRequested;
 use Modules\Core\Privacy\Jobs\ExportDataSubjectJob;
 use Modules\Core\Privacy\Models\DataErasureRequest;