Feat: Adding hashes for otp codes
This commit is contained in:
@@ -0,0 +1,43 @@
|
||||
<?php
|
||||
|
||||
use Illuminate\Database\Migrations\Migration;
|
||||
use Illuminate\Database\Schema\Blueprint;
|
||||
use Illuminate\Support\Facades\Schema;
|
||||
|
||||
/**
|
||||
* otp_code was stored in plaintext (a raw 6-digit string) and compared
|
||||
* with hash_equals() against the plaintext guess in
|
||||
* Modules\Core\Auth\Services\UserOtpService — hash_equals() only
|
||||
* prevents a timing attack, it does nothing to protect the code itself
|
||||
* from anyone with read access to the row. Replaced with a bcrypt hash,
|
||||
* same pattern Modules\Core\Customer\Services\CustomerEmailChangeService
|
||||
* already uses for its own pending_email_code_hash column.
|
||||
*
|
||||
* No backfill: any code mid-flight when this deploys is invalidated —
|
||||
* codes expire in 10 minutes anyway, so the real-world impact is a
|
||||
* shopper re-requesting one, not lost work.
|
||||
*/
|
||||
return new class extends Migration
|
||||
{
|
||||
public function up(): void
|
||||
{
|
||||
Schema::table('users', function (Blueprint $table) {
|
||||
$table->string('otp_code_hash')->nullable()->after('password');
|
||||
});
|
||||
|
||||
Schema::table('users', function (Blueprint $table) {
|
||||
$table->dropColumn('otp_code');
|
||||
});
|
||||
}
|
||||
|
||||
public function down(): void
|
||||
{
|
||||
Schema::table('users', function (Blueprint $table) {
|
||||
$table->string('otp_code', 6)->nullable()->after('password');
|
||||
});
|
||||
|
||||
Schema::table('users', function (Blueprint $table) {
|
||||
$table->dropColumn('otp_code_hash');
|
||||
});
|
||||
}
|
||||
};
|
||||
@@ -0,0 +1,37 @@
|
||||
<?php
|
||||
|
||||
use Illuminate\Database\Migrations\Migration;
|
||||
use Illuminate\Database\Schema\Blueprint;
|
||||
use Illuminate\Support\Facades\Schema;
|
||||
|
||||
/**
|
||||
* Same fix as 2026_09_30_000001_hash_otp_code_on_users_table.php, for
|
||||
* staff logins — see that migration's own docblock. This path was
|
||||
* additionally weaker: Modules\Core\Auth\Services\OtpService compared
|
||||
* with a loose != rather than hash_equals(), so it had no timing-attack
|
||||
* protection at all on top of the plaintext storage.
|
||||
*/
|
||||
return new class extends Migration
|
||||
{
|
||||
public function up(): void
|
||||
{
|
||||
Schema::table('lunar_staff', function (Blueprint $table) {
|
||||
$table->string('otp_code_hash')->nullable()->after('password');
|
||||
});
|
||||
|
||||
Schema::table('lunar_staff', function (Blueprint $table) {
|
||||
$table->dropColumn('otp_code');
|
||||
});
|
||||
}
|
||||
|
||||
public function down(): void
|
||||
{
|
||||
Schema::table('lunar_staff', function (Blueprint $table) {
|
||||
$table->string('otp_code', 6)->nullable()->after('password');
|
||||
});
|
||||
|
||||
Schema::table('lunar_staff', function (Blueprint $table) {
|
||||
$table->dropColumn('otp_code_hash');
|
||||
});
|
||||
}
|
||||
};
|
||||
Reference in New Issue
Block a user